search

Jimdo / angular-fontselect

A fontselect directive for AngularJS
MIT License
29 stars 9 forks source link

Fixing wheelDeltaY issue on chrome #41

Closed jquinter closed 9 years ago

jquinter commented 9 years ago

On chrome thsis error appears

Uncaught TypeError: Cannot read property 'wheelDeltaY' of undefinedangular-fontselect.js:1302 fontselectModule.controller.wheelHandlerangular.js:3011 eventHandler

screenshot 2015-03-11 23 45 47

By asking the type of event, it is possible to bypass the error.

Xiphe commented 9 years ago

Hey @jquinter ! Thanks for your PR. Unfortunately, i'm not able to reproduce this on Chrome 41 on Mac OSX 10.10. Can you please provide "steps to reproduce" along with the exact browser/OS combination you're using?

Besides that, please do not contribute changes on the dist/ files itself. These are generated automatically when a new version is released. (see CONTRIBUTE.md) The file, you might want to work on is this: https://github.com/Jimdo/angular-fontselect/blob/master/src/js/directive.fontlist.js#L133

And please ensure that the code-style stays intact by using { and } for the body of an if-statement (grunt test includes jshint tests, which may help here)

Xiphe commented 9 years ago

closing since stale.

feel free to reopen if this is sill an issue.