Rely on bucket count instead of hIncrByFloat return value

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications

https://prometheus.io/docs/concepts/metric_types/

Apache License 2.0

281 stars 213 forks source link

Rely on bucket count instead of hIncrByFloat return value #112

Open akondas opened 5 years ago

akondas commented 5 years ago

This PR fix problem with floats, sometimes first value in the bucket can be different in PHP and Redis. In this case, the metric key will not be created correctly. Test case can show you more.

akondas commented 5 years ago

Hey @bracki any updates?