search

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
281 stars 213 forks source link

Replace/rewrite InMemory adapter #20

Closed bracki closed 7 years ago

bracki commented 8 years ago

With #18 we removed all usages of the InMemory adapter. Either remove it altogether or rewrite it.

krukru commented 7 years ago

Any explanation why this got removed? I have some gauges that I don't really need to store in redis/apc, InMemory would be just fine for the job. I just need the renderer (RenderTextFormat), which I can't seem to use without a valid redis or apc adapter.

bweston92 commented 7 years ago

Ok I seem to have just implemented my ReactHTTP server with this package and only just realised that there is no stats because of no code in the in memory adaptor. Any idea on getting this in?

krukru commented 7 years ago

I have a pull request that implements the in memory adapter, but I haven't received any feedback on it for a while now. You can use my fork until we get some comment on the PR

bracki commented 7 years ago

Will be fixed by merging #36.

bracki commented 7 years ago

Done.