search

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
281 stars 213 forks source link

Allow passing already configured redis client to the storage adapter #27

Open bdudelsack opened 8 years ago

bracki commented 8 years ago

What's the benefit of reuse here?

bdudelsack commented 8 years ago

In my application i already have configured Redis instance, so i don't need to make another one at the point of prometheus client creation.

Actually i think that redis configuration should be taken out of the library and the end user should instantiate it by himself because it out of scope of the lib.

NoelDavies commented 5 years ago

This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there.