search

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
281 stars 213 forks source link

Remove Redis Requirement #38

Closed michaeljs1990 closed 7 years ago

michaeljs1990 commented 7 years ago

I don't feel like you should have to install redis to use this library. This makes it so that you can use the library without having fatal errors thrown due to a missing optional dependency like redis.

michaeljs1990 commented 7 years ago

Wanted to use this without having to install php5-redis as it does show as an optional dependency which is not actually the case.

bracki commented 7 years ago

While I agree that using the library without php5-redis is desirable, I don't see any point in adding changes for EOLed PHP version. Please remove the other two commits.

michaeljs1990 commented 7 years ago

Sounds good to me i'll clean it up, thanks for taking a look.

bracki commented 7 years ago

Closing due to inactivity.