Replace double data type with float data type

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications

https://prometheus.io/docs/concepts/metric_types/

Apache License 2.0

281 stars 213 forks source link

Replace double data type with float data type #49

Closed bsacharski closed 7 years ago

bsacharski commented 7 years ago

It looks like the library uses double keyword for a phpdoc comments in some places. PHP doesn't really differentiate between float and double with the former being much more common. IMHO it makes it confusing when reading the code. Additionally, some tools may not handle double data type correctly (for instance PHPStan). Therefore I would suggest switching double to float.

bracki commented 7 years ago

According to https://github.com/phpstan/phpstan/issues/214 double support landed in PHPStan. I'd rather keep it as is.