search

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
281 stars 213 forks source link

Add Predis support #55

Open fesor opened 7 years ago

fesor commented 7 years ago

For #52

fesor commented 6 years ago

@schnipseljagd @bracki guys, what do you think on this?

bracki commented 6 years ago

I'd prefer to refactor the class so that it takes either a Redis or a Predis $connection, rather than duplicating everything. @fesor what's your take on that?

fesor commented 6 years ago

Will try to do that.

fesor commented 6 years ago

@bracki so, I need this again so I finally managed to work on this PR.

I added additional abstraction which hides difference between redis and predis without sacrifice lazy connection in case of redis.

I really not sure it is ok or not.

bracki commented 6 years ago

@fesor Would you mind rebasing? Did you also take into account #27?

fesor commented 6 years ago

@bracki as for #27, yes and no. You can pass redis instance but adapter still will handle connection and will require connection options.

I need to check is this covers #27 fully.

Willl rebase this PR asap.

peterjumpnl commented 6 years ago

What is status of this pr?

MyIgel commented 5 years ago

Is there anything I could help with this PR to get merged? This would be a really nice feature :(

NoelDavies commented 5 years ago

This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there.