search

Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
281 stars 213 forks source link

Introduce persistent_id for persistent connections #87

Open rdohms opened 6 years ago

rdohms commented 6 years ago

When using predis extension, the underlying library will re-use connections to same host/port in case of persistent connections. This becomes an issue when the user's application uses the same host of Redis but has different databases, meaning that this library will write to whichever database is previously used by other parts of the code.

Using a persistent id forces the library to create a new connection that will not conflict with any other connections being used by the application.

NoelDavies commented 5 years ago

This project is dead, but I'm maintaining it under my employer - https://github.com/endclothing/prometheus_client_php. Feel free to submit the PR there.