Jimdo / prometheus_client_php

Prometheus instrumentation library for PHP applications
https://prometheus.io/docs/concepts/metric_types/
Apache License 2.0
281 stars 213 forks source link

fix(client): fix server address allowing https #98

Closed Gounlaf closed 5 years ago

Gounlaf commented 5 years ago

Use Psr7\Uri (from guzzle dependencies) to build PushGateway::$address, allowing support of https

oroshnivskyy commented 5 years ago

Hi @Gounlaf look at that PR: https://github.com/Jimdo/prometheus_client_php/pull/107 I think it will be better to move guzzle client configuration outside of PushGateway class

Gounlaf commented 5 years ago

Close in favor of #107