JimiIT92 / UniverseGuard2

An easy to use world protection plugin for Sponge
https://ore.spongepowered.org/Francesco_Jimi/Universe-Guard
GNU General Public License v3.0
19 stars 3 forks source link

Bug with itemDrop flag #125

Closed IXaar1 closed 4 years ago

IXaar1 commented 4 years ago

Hi! When you deny itemDrop flag in region you can still drop items. All you need to do is open inventory, click on item and press escape button, so item will drop :) Please fix this.

JimiIT92 commented 4 years ago

Hi, I've tested this and what I got is that the item get destroyed, as by design. So if you can please share me the region file, as it could happen with a particular region configuration, that would be helpful

IXaar1 commented 4 years ago

Sorry for being late. Try to represent it in survival mode. Here is rg file(cant attach it to github) : https://mega.nz/file/QVpljT4A#Q4dnG-7CFZbOwmWAevyAq4gKF7F5r_mc-C5NxfTqbsI

Here is a video, that may help you :) sorry for my spoken english :D (i am from Russia) https://mega.nz/file/QN5nXbgB#kh0YwdjvtTfEq2BcrkhcjbzN29yNzKo_yQPZ0G7Uhq8

JimiIT92 commented 4 years ago

Thank you for the Region file and the video (very helpful)! I will try as soon as I can to see if I can reproduce the issue and understand why it happens EDIT: The Region file link is wrong, you posted the Minecraft file while instead I need the file in the config/regions for the Region you are having the issue. You will find a file called "index.json" where it will tell you how the file is called based on the Region name

IXaar1 commented 4 years ago

Sorry for misunderstand. Attached new region file: https://mega.nz/file/EYJGia4J#wZbMio4WLXn5KH-PCXotRLnK-S58fUJoZUCZxuS0iOg

JimiIT92 commented 4 years ago

Thank you for the file, it really helped to identify the issue that should now be resolved in version 2.27! https://ore.spongepowered.org/Francesco_Jimi/Universe-Guard/versions/2.27

Vulant commented 3 years ago

I just want to say, thank you for the fix and thank you for reporting this issue. I just discovered this bug which would have completely broken a mechanic I'm working on, I'm so glad this was reported before me and fixed.

Vulant commented 3 years ago

I also want to note, that if players spam-attempt trying to throw items out of their inventory using the method described above, that item can disappear / be deleted. If it reappears on your cursor or in your inventory, it could be a ghost-image. Clicking on the item again would make it disappear. Not an issue for me but may be an issue for others.