JimiIT92 / UniverseGuard2

An easy to use world protection plugin for Sponge
https://ore.spongepowered.org/Francesco_Jimi/Universe-Guard
GNU General Public License v3.0
19 stars 3 forks source link

RLCraft causing issues/not firing events #177

Open ShockCharge opened 3 years ago

ShockCharge commented 3 years ago

Flags not working at all image

Players can still break blocks in my spawn and place blocks also other flags isn't working at all such as Firespread i already have it by false by default and it still persist.

Sponge Version: image

Forge Version: image

UniverseGuard Version: image

JimiIT92 commented 3 years ago

Can you share your spawn region file? Also make sure default vanilla spawn protection is set to 0 and players don't have permissions or are listed as members of the region

ShockCharge commented 3 years ago

You can come on my forge server: play.bluemountainmc.fun then do /server rlcraft to test some things if you want.

image Spawn with a Priority 2: https://pastebin.com/NL9ARqwU Outside Spawn with a Priority 1: https://pastebin.com/910k3br1

I also updated my SpongeForge to the newest build to this image

ShockCharge commented 3 years ago

(Edit) After Updating my ForgeSponge everything worked fine except

  1. Players can interact with Armorstand they can take items on it and place it back
  2. Destroy is still working even though its already on False

^ You can check the Spawn Priority 2 pastebin i've send above.

JimiIT92 commented 3 years ago

Ooooh so you are using RLCraft? Yeah, that caused some troubles in the past... Can you send me a list of all the mods on the server, if not just the RLCraft modpack? As in that modpack there are some blocks that looks like are not detected by the Sponge events for placing or beaking, so if you know also some blocks where protections are not working that would be extremely helpful

ShockCharge commented 3 years ago

image image image image image image image

ShockCharge commented 3 years ago

Not just in the modpack itself but normal blocks such as carpet, leaves, grass can be break.

JimiIT92 commented 3 years ago

I managed to setup a local RLCraft server. I already found some issues with some mods that for some reason are taking over every kind of permissions (even vanilla ones!). So 99% there's a mod that is bypassing all sorts of protections, now the question is which one it is 😅 Will see if I can find anything

ShockCharge commented 3 years ago

Mhm you can also check on my permissions as well if you want. I'm using Luckperms latest version https://luckperms.net/editor/OticDLIDKx

Ayoku98 commented 3 years ago

+1 on issue where can break blocks even though destroy flag is false Setup Pixelmon Reforged with additional few server util mods I did grab from a recent RLCraft server Ill list my mods if itll help narrow a few of them down image

JimiIT92 commented 3 years ago

Thank you for the list of mods. Unfortunately to address the issue I have to check each of this mod to see which onen is causing issues and why. And doing that on RLCraft will require a ton amount of time, as there are like hundreds of mods in there IIRC 😥 I already found out some mods of that package that causes issues not only with the plugin but with Sponge in general, as for some reason Sponge events are not fired at all when these mods are running (that's why plugin doesn't seem to work, because there's no event to listen for). Specifically I find out that the FirstAid mod (the one that give you localized health bars) blocks events related to damage, making all damage related flags (like pvp, pve, etc...) basically useless. I already reported the issue on the mod's GitHub, hoping to get in touch with the mod's author to figure out what is going on. Another one that is causing weird things is the mod that causes blocks to "pop up" when placed down (which I don't know its name). What I found is that if you spam the placing of a block there is a chance that the block gets placed, regardless the event being canceled. What's even stranger is that the block has collisions as if is actually placed, however if you interact in any manner with it, it will disappear, as it was a "ghost client-only block". So there's definitively something going on, but seems to me that is something related more to Sponge itself not catching/canceling events properly. I updated the title so others can see it is related specifically to RLCraft, and maybe avoid opening new issues about this modpack. Will see in these days what else I can found 😉

Ayoku98 commented 3 years ago

Another one that is causing weird things is the mod that causes blocks to "pop up" when placed down (which I don't know its name)

I believe that one is called Fancy Block Particles

Ayoku98 commented 3 years ago

@JimiIT92 - at least for my issue, the mod allowing others to still break blocks even though the destroy flag is false is Multi Mine -- even if the server removed it, as long as the client has it - it will still work on the client and bypass the region flag

Ayoku98 commented 3 years ago

@JimiIT92 - Carry On mod bypasses permission too

ShockCharge commented 3 years ago

Well appearently some mods on RLCraft are pretty outdated unless i remove the mods that might cause an issue to the pack or i update it as well which will cause more issue.

I think you have to really make a global deny for this blockbreakevent.

JimiIT92 commented 3 years ago

Well appearently some mods on RLCraft are pretty outdated unless i remove the mods that might cause an issue to the pack or i update it as well which will cause more issue.

I think you have to really make a global deny for this blockbreakevent.

The problem is that some mods don't even fire events that can be catched and cancelled, which is really really weird