search

JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
738 stars 156 forks source link

Fix typos #1020

Closed kianmeng closed 7 months ago

kianmeng commented 7 months ago

Found via codespell -S ./calibre-plugin/translations,./included_dependencies,./tests/fixtures_chireads.py -L dne,pres,signes,curren,als,ist,buss,serie,nd,waring,couldn,vie

JimmXinu commented 7 months ago

Do any of these changes fix functional problems? Or correct things that could cause misunderstanding?

I'm not very inclined to accept this PR because:

  1. For the one UI string this changes, the same reasons as #1011 apply.
  2. The change to several adapters "...not been validated by the adminstrators...": I suspect it would break the code--that string was copy/pasted from the eFiction site response, typo and all.
  3. Of the rest, the vast majority are in comments and I don't think any obscure the meaning.

I am always leery of wide spread changes without specific reason. In my experience, the minor improvement they may make is outweighed by the extraneous differences when you are trying to diff a change or branch.

kianmeng commented 7 months ago

@JimmXinu Noted, and thanks for letting me know. I will close this PR.