search

JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
737 stars 156 forks source link

adapter_ficbooknet: Fix breakage for proxies & add covers #1077

Closed dbhmw closed 4 weeks ago

JimmXinu commented 1 month ago

Reference: #1076

dbhmw commented 4 weeks ago

Tested with many stories and haven't encountered a problem with or without nsapa, i would say this is ready. Although testing was done using CLI. i haven't used the calibre plugin, will it make a difference? @JimmXinu

JimmXinu commented 4 weeks ago

Works in recent Plugins, but there's some weird issues with older py2 versions. I'll address them after this is merged in.

JimmXinu commented 4 weeks ago

53a7a60dbcec3450cdb45f893f27b63c8eaaf269 I don't know what was going on with the regex. I didn't fix pages, just bypassed it when it fails.

dbhmw commented 4 weeks ago

53a7a60 I don't know what was going on with the regex. I didn't fix pages, just bypassed it when it fails.

Sorry for the late response. Could you try the 142e9fd to see if this fixes the issue on windows? The date is failing on calibre 2.85.1 on linux. This fixes it and pages at least there but i don't have the ability to test it on win.

JimmXinu commented 4 weeks ago

I've included that change as ef66e73fa44afe305d13cf8da260e3c2b2447e5a -- I couldn't figure out how to pull in your commit directly.