search

JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
768 stars 165 forks source link

Minor Bug in RoyalRoad #287

Closed Twilight666 closed 6 years ago

Twilight666 commented 6 years ago

Once again in RoyalRoad here:

https://royalroadl.com/fiction/8894/everybody-loves-large-chests/chapter/129451/not-a-chapter-skill-compendium

This time there are spoilered parts that are hidden by default. I tried using these:

legend_spoilers:true remove_spoilers:false

And it did not work. I checked and the spoilered parts were downloaded they are just hidden (display:none)

JimmXinu commented 6 years ago

remove_spoilers and remove_spoilers are specific to the base_xenforoforum sites--which does not include RoyalRoad. So no surprise they didn't work.

What would (probably) work is removing style from add_to_keep_html_attrs again because it's the style attr that's hiding them.

Unless you can show that those show/hide boxes are a feature of the site and not just HTML the author put in, I'm not interested in adding custom code to deal with them.

Twilight666 commented 6 years ago

Here screen I used the site's editor to add a spoiler. From what I can see it works similarly to the xenforo sites

JimmXinu commented 6 years ago

Okay. I'll look into adding similar code for that site as for xenforo. Be patient, it may be a week before I get to it.

Twilight666 commented 6 years ago

Also here:

https://royalroadl.com/fiction/17051/bunkercore

This one also has spoiled parts too but it's only 15 chapters so it should be easier to use for code development

JimmXinu commented 6 years ago

Test posted versions in the usual places for CLI, web service and plugin.

JimmXinu commented 6 years ago

User chose to open a new issue rather than continue this one.