JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
750 stars 161 forks source link

Can't download story on QQ if author's account is guest/deleted #852

Closed kido5217 closed 2 years ago

kido5217 commented 2 years ago

Story example: https://forum.questionablequesting.com/threads/greg-the-hero.16576/

Error:

fanficfare 'https://forum.questionablequesting.com/threads/greg-the-hero.16576/'
Traceback (most recent call last):
  File "/usr/bin/fanficfare", line 33, in <module>
    sys.exit(load_entry_point('FanFicFare==4.13.2', 'console_scripts', 'fanficfare')())
  File "/usr/lib/python3.10/site-packages/fanficfare/cli.py", line 344, in main
    dispatch(options, urls, passed_defaultsini, passed_personalini, warn, fail)
  File "/usr/lib/python3.10/site-packages/fanficfare/cli.py", line 320, in dispatch
    do_download(url,
  File "/usr/lib/python3.10/site-packages/fanficfare/cli.py", line 435, in do_download
    adapter.getStoryMetadataOnly()
  File "/usr/lib/python3.10/site-packages/fanficfare/adapters/base_adapter.py", line 308, in getStoryMetadataOnly
    self.doExtractChapterUrlsAndMetadata(get_cover=get_cover)
  File "/usr/lib/python3.10/site-packages/fanficfare/adapters/base_adapter.py", line 412, in doExtractChapterUrlsAndMetadata
    return self.extractChapterUrlsAndMetadata()
  File "/usr/lib/python3.10/site-packages/fanficfare/adapters/base_xenforoforum_adapter.py", line 565, in extractChapterUrlsAndMetadata
    self.parse_author(souptag)
  File "/usr/lib/python3.10/site-packages/fanficfare/adapters/base_xenforoforum_adapter.py", line 621, in parse_author
    self.story.addToList('authorId',a['href'].split('/')[1])
  File "/usr/lib/python3.10/site-packages/bs4/element.py", line 1486, in __getitem__
    return self.attrs[key]
KeyError: 'href'
JimmXinu commented 2 years ago

New test versions posted as usual.

kido5217 commented 2 years ago

Works for me. Thank you.