search

JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
750 stars 161 forks source link

Fanficfare can't handle '[' in series title on ao3 #875

Closed maxsone closed 2 years ago

maxsone commented 2 years ago

AO3 series titles that contain '[' breaks download with ValueError when it tries to find series_index.

To reproduce, try downloading:

https://archiveofourown.org/works/33701344 or https://archiveofourown.org/works/15727008

I don't understand what

if '[' in series:

at ~436 in writer_epub.py is doing, but perhaps it should check if the content is_numeric?

JimmXinu commented 2 years ago

That's only an issue when calibre_series_meta is set true.

Fixed by changing index() to rindex() 7558c998df595111ac04e1eb8188567aa2e6910e

CLI test version uploaded.