search

JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
746 stars 158 forks source link

Support classic AND modern (and minimalist) theme for storiesonline, … #893

Closed mvlcek closed 1 year ago

mvlcek commented 1 year ago

…finestories and scifistories

After wondering why I couldn't download from finestories and finding out that it only supported modern theme as opposed to the other sites, I moved the existing code from finestories (which required modern theme) to the parent storiesonline adapter and adapted it so that all themes are supported.

JimmXinu commented 1 year ago

I will accept this PR only if you agree to handle any issues that come up with it.

These sites are already a pain to support and having to test and maintain for multiple skins for them is more work than I care to deal with.

mvlcek commented 1 year ago

Then I don't understand, why finestories used the modern theme instead of the classic one. Just removing the special handling in the finestories adapter and thus supporting only classic theme over all adapters also works.

For now it works with all themes, but it will tell the user to use the classic theme in the case of a problem, this being the officially supported theme.

As I'm (currently) using all of these adapters, I should notice any problems and will then also try to fix at least the classic theme.

JimmXinu commented 1 year ago

As I recall, new finestories accounts default to modern instead of classic. Test versions posted.