JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
746 stars 158 forks source link

Languages in ao3 #906

Closed aRoboticsGirl closed 1 year ago

aRoboticsGirl commented 1 year ago

For some stories the metadata says that they are in English when they are not. I don't think that it is an error in my settings. I have several hundred mislabeled stories downloaded. I am assuming it is because the program does not recognize the language(s) and defaults to English. Languages that are not recognized should be left blank or given some other indicator to show they are not in English. I will leave some example of stories that say they are in English in the metadata, but are not: https://archiveofourown.org/works/25309468 https://archiveofourown.org/works/34860724 https://archiveofourown.org/works/10052939 https://archiveofourown.org/works/38651820 https://archiveofourown.org/works/16814413 https://archiveofourown.org/works/21069650 https://archiveofourown.org/works/43860867 https://archiveofourown.org/works/9480902

JimmXinu commented 1 year ago

FFF directly saves the Language string as given by AO3 for use in title page etc in the language metadata entry. So that should always be correct. You can set that to a Calibre custom column if you want.

OTOH, the langcode metadata entry contains the ISO 639-X code for the language, mapped using a hard coded list in FFF. And AO3 has updated their language list since FFF last updated.

The langcode is used to set Calibre's builtin language column, so I assume you are talking about seeing English here.

Updated in 020d8d9e5b88c44e697cb2015f3b0ecf6981b4e5 and new plugin test version posted.

Here's what I'm getting now for your reported stories: Calibre languages

Note that Calibre doesn't have separate values for 'Português brasileiro' and 'Português europeu', even though FFF did split them into pt-BR and pt-PT.

aRoboticsGirl commented 1 year ago

Creating a custom column has fixed the problem for me. Thank you for your help.