search

JimmXinu / FanFicFare

FanFicFare is a tool for making eBooks from stories on fanfiction and other web sites.
Other
746 stars 158 forks source link

Dates are not correctly detected on Deviantart #910

Closed bugmaschine closed 1 year ago

bugmaschine commented 1 year ago

If the dates are formated like "3 days ago" for example its causes a crash

JimmXinu commented 1 year ago

Have you looked at the existing parse_relative_date_string() in fanficfare/dateutils.py? It seems to be very similar.

bugmaschine commented 1 year ago

I modified the code to use the existing function, but the existing code had to be modified i hope this works

bugmaschine commented 1 year ago

Maybe now?

JimmXinu commented 1 year ago

This still needed some tweaking and I didn't want to spend more time going back and forth. Merged in with 5ce7aa5c48370399204e9f7cf2f753b7ce82da94

Please test, I couldn't find and deviantart stories with Yesterday or just now.

bugmaschine commented 1 year ago

Tested it with Yesterday and just now and both work

JimmXinu commented 1 year ago

Okay, thanks.