Closed niacdoial closed 1 year ago
I'd like a few changes before accepting this:
This should be a new configuration switch such as use_workskin
.
Inclusion of style
in keep_html_attrs
shouldn't be the controlling element. If anything, an author using inline styles probably indicates they don't use workskin CSS.
Search for use_view_full_work
in fanficfare/configurable.py
(in two places), fanficfare/defaults.ini
, and calibre-plugin/plugin-defaults.ini
for examples of what to add where.
I'd appreciate comments in story.py
and base_writer.py
about extra_css
that refer to the new setting.
FFF is still back compatible to old versions of Calibre in python2. Please use from ..six import text_type as unicode
and unicode
instead of str
for consistency.
done! I also spotted while searching that AO3 was not the only site to use use_view_full_work
thanks!
That pointed out to me that squidgeworld also shares all settings with AO3, so I made some more lists.
However, while testing this, it occurs that the CSS order should be workskin, then output_css
setting so user can override workskin in personal.ini
.
oh. well, I got a new commit out that fixes that, if you didn't do so on your side yet
@niacdoial just wanted to thank you personally for letting me download a story that had tricky CSS that I couldn't get working manually!
If the "keep_html_attrs" config parameter includes "style", add the workskin (for AO3 works that have one) to the ebook's stylesheet.