Allow class members to set their serialized name with the DoSave attribute

[JimmyCushnie]

Instead of making DoSave dual-purpose, should we instead have a separate SaveAs attribute?

[pipe01]

I think I prefer how it is, having two attributes per member may be slightly cumbersome

[JimmyCushnie]

Remember you can combine attributes, like so: [DoSave, SaveAs("exampleName")]. I think it's good practice to have separate attributes for separate purposes

[pipe01]

How about if you have the SaveAs attribute you don't need the DoSave one

[JimmyCushnie]

Hmm. I'm not a huge fan, since that's again combining two purposes into one attribute.

However if the attributes are separate, it seems unintuitive for something marked with SaveAs to not be saved.

OK, here's my proposal. Keep the system you've made here, with DoSave being used both to save private members and to set the name of a saved member. However, rename the attribute's Name property to SaveAs, and remove the attribute constructor so that you're forced to explicitly declare what the string does.

[DoSave(SaveAs: "ShortName")]
private int StupidNameWhichIsVeryLongAndStupid;

I'm also thinking DoSave and DontSave should be renamed to SaveThis and DontSaveThis.

[pipe01]

Sounds good

[JimmyCushnie]

Awesome stuff, if you can just move ClassMember to the SUCC.ParsingLogic namespace I'll merge :)

[pipe01]

I did! The commit isn't shown here for whatever reason

[JimmyCushnie]

Ah so you did! My bad lol.

Thanks for a great PR!