Suggestions about request and bluebird

[f1she3]

Hi ! A big thanks for this library that I use and find really useful. Just a quick suggestion about two libraries it depends on :

• request (deprecated)
• bluebird

Since request is deprecated, I could rewrite the http requests using the native https module which performs very well. And for bluebird since promises are now part of nodeJS, I think everything could be done natively, but maybe you see other benefits about using it :)

I would be interested to have your thoughts about this, and could start working on it if you'd like to.

Have a nice day

[JimmyLaurent]

Hello,

First of all thanks for proposing your help and sorry for the delay.

• request: I'm not a huge fan of using node native http modules, they're really basic and don't handle proxies, redirections, gzip, and forms handling out of the box. We would have to rewrite some helpers and it's not the goal of this package. I have heard about a maintained fork of "request" but I can't find it. I'm open to using another lib, it would have to support HTTP_PROXY and HTTPS_PROXY env variables and have a simple api.

• bluebird: I'm ok with removing bluebird, It's only used to promisify some native apis (ex: fs.writeFile) and now there's some native promisified APIs in the latest releases of node.

[f1she3]

Hi !

Sorry for the delay too, I have a limited amount of time currently 😁 I started rewriting almost every provider using https://github.com/axios/axios except rarbg because the provider supports authentication and I don't have credentials to test the code, but it works well for the others. I think I only have to rewrite the request method now in lib/Torrent provider.js , and a big part of the job would be done. I could make a pull request with the changes I already made if you'd like to, so that anybody could potentially finish the job if I don't find the time.

I will try to replace bluebird also, this should not take a lot of time.

Have a nice day !

[f1she3]

Any news from this ?