search

Jin-prgrmng / my_portfolio_site

my portfolio site
https://jin-prgrmng.github.io/my_portfolio_site/
0 stars 0 forks source link

Smooth scrolling #1

Open Jin-prgrmng opened 4 years ago

Jin-prgrmng commented 4 years ago

Good afternoon. I think that it will be better if the screen transitions on my site are smoother.

oladhari commented 4 years ago

please add a checklist of steps to do to make your site smoother and when you open a PR please assign me for the review

Jin-prgrmng commented 4 years ago
1. I add this( https://fukafuka295.jp/smooth_scroll/ ) code to my portfolio site code. 2. Check moving on my site.
oladhari commented 4 years ago

https://fukafuka295.jp/smooth_scroll/

better to write like this a checklist

Jin-prgrmng commented 4 years ago

thank you for teaching me ! this style is good for understanding!

Jin-prgrmng commented 4 years ago

this code of website is ok...? i don't know JQuery well...

oladhari commented 4 years ago

this code of website is ok...? i don't know JQuery well...

why trying a javascript solution, try first CSS solutions:

html {
  scroll-behavior: smooth;
}

NB: not supported in safari browsers indeed

Jin-prgrmng commented 4 years ago

Oh sorry! i'll send a chrome after that! i tried your code( at html,body and container-wrapper). but it did not work... where I write this code...?

oladhari commented 4 years ago

Oh sorry! i'll send a chrome after that! i tried your code( at html,body and container-wrapper). but it did not work... where I write this code...?

I see what browser are you using?

oladhari commented 4 years ago

and when you change the code could you do PR (pull requests)

Jin-prgrmng commented 4 years ago

Oh sorry! i'll send a chrome after that! i tried your code( at html,body and container-wrapper). but it did not work... where I write this code...?

I see what browser are you using?

i always use chrome. but sometime use safari.

Jin-prgrmng commented 4 years ago

and when you change the code could you do PR (pull requests)

i just found out when i should send PR... i'll do it after that !

Jin-prgrmng commented 4 years ago

i try to send PR for you. can you see my PR ...?

oladhari commented 4 years ago

i try to send PR for you. can you see my PR ...?

I wrote a comment on your PR

Jin-prgrmng commented 4 years ago

thank you! i'll try it !!

oladhari commented 4 years ago

the name of the JS file is not the same mentioned in the HTML file, please fix it

Jin-prgrmng commented 4 years ago

I done it.　thank you.

oladhari commented 4 years ago

ok now the smooth scrolling is working?

Jin-prgrmng commented 4 years ago

No, it doesn't work. where i misstake...?

Jin-prgrmng commented 4 years ago

Are you OK...?

oladhari commented 4 years ago

お疲れ様です！ sorry I had many bugs at work today and yesterday I was so busy I will check this tomorrow, as I am so tired but you can advance on block, you already resolved 2 issues :+1:

Jin-prgrmng commented 4 years ago

Oh... That must have been tough. Thank you !

oladhari commented 4 years ago

there is here an example with vanilla javascript:

Jin-prgrmng commented 4 years ago

I want to learn about JavaScript at next stage !! Thank you !!