Jin-prgrmng / my_portfolio_site

my portfolio site
https://jin-prgrmng.github.io/my_portfolio_site/
0 stars 0 forks source link

move the style code to related CSS file #7

Closed oladhari closed 4 years ago

oladhari commented 4 years ago

you have added style in HTML file which is not the most accurate way to do please gather all CSS code in one unique file

all these operations should be done in one PR no need to open a PR for every commit

oladhari commented 4 years ago

how you do 2 PRs? why you create 2 branches??? just do one branch with all needed changes and do commit ! do you know how to do commit?

Jin-prgrmng commented 4 years ago

sorry. I intend to commit. but in fact, I don't. I learn "commit" again...

Jin-prgrmng commented 4 years ago

I learned about Github more. So I want to start again.

oladhari commented 4 years ago

ok no worries, please do a PR with all needed changes

Jin-prgrmng commented 4 years ago

Ok. thank you. I'll use the branch named "Jin-prgrmng-patch-1-2".

Jin-prgrmng commented 4 years ago

i send PR to you now.