search

JingHaoooo / pe

0 stars 0 forks source link

newDrink command allows parameters to be all 0. #6

Open JingHaoooo opened 6 months ago

JingHaoooo commented 6 months ago

image.png

It might not make sense to allow users to submit 0 for every single category.

nus-pe-bot commented 6 months ago

Team's Response

Some drink have 0 calories, carbs, etc. For example, carbonated water, sparkling water.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While i acknowledge that water can have 0 for everything, similar bugs was also seen in commands such as newMeal and newExercise. However, I did not report it as they were all similar to this bug.

Take for example: similar bug could be done using the command "newMeal mie,0,0,0,0,0,0". This would mean that the meal named mie would have 0 for everything.

image.png

In addition, based on information found online, there is no food item that can have 0 calories, 0 carbs, 0 protein, 0 fats, 0 fiber, and 0 sugar. Food, by definition, provides nourishment to the body in the form of energy (calories) and essential nutrients (carbohydrates, protein, fats, vitamins, minerals). Even fruits and vegetables, which are typically low in calories and fat, contain some amount of carbohydrates, fiber, vitamins and minerals.

Hence, this should be considered as a bug as it makes no sense.