search

JingMatrix / ChromeXt

UserScript and DevTools supports for Chromium based and WebView based browsers
https://jingmatrix.github.io/ChromeXt/
GNU General Public License v3.0
700 stars 39 forks source link

`Enable reader mode manually` for `Chrome Custom Tabs` #120

Closed chuwza closed 1 year ago

chuwza commented 1 year ago

Hi, sorry, not sure if so many Issues are bothering you. So thank you for your work.😀

I found a bug now, such is picture, "Enable reader mode manually" can works in normal web, but doesn't work in "Custom Tabs" Screenshot_20230925-202852_Chrome~2

JingMatrix commented 1 year ago

That is an intentional design of ChromeXt. Since you can use the Open in Chrome menu, I personally don't find the reason to replace the icon row menu.

chuwza commented 1 year ago

That is an intentional design of ChromeXt. Since you can use the Open in Chrome menu, I personally don't find the reason to replace the icon row menu.

Understand your intentional design, but maybe you can hear my usage scenario.

For me, the most frequent scenario for turning on reading mode is Custom Tabs, not general web pages. Because I use Custom Tabs to read the news, finish reading, and go straight back, and reading the news is great for turning on Reading Mode, I hardly ever turn on reading mode when I use my browser for normal web browsing.

So could you please add this Feature? I really need it.🤤

JingMatrix commented 1 year ago

If I remeber it correctly, the modfication for custom tabs is slightly more difficult (which is part of the reason for this intentional design). It takes some time to do that, but will be implemented soon.

chuwza commented 1 year ago

If I remeber it correctly, the modfication for custom tabs is slightly more difficult (which is part of the reason for this intentional design). It takes some time to do that, but will be implemented soon.

OK, Thank you very much🥳

JingMatrix commented 1 year ago

Now this is implemented. Keep in mind one rule: if you couldn't find the reader mode icon, it is because that you never have opened the page menu once in the Chrome application.

To keep ChromeXt less complicated, the above rule, though not perfect for user experience, won't be fixed for now.

chuwza commented 1 year ago

Now this is implemented. Keep in mind one rule: if you couldn't find the reader mode icon, it is because that you never have opened the page menu once in the Chrome application.

To keep ChromeXt less complicated, the above rule, though not perfect for user experience, won't be fixed for now.

Hello, there may still be some problems with this feature, I clicked on the reader mode icon, but nothing happened.

https://github.com/JingMatrix/ChromeXt/assets/30049891/c85a3ba5-5a45-427a-91a1-c4b09206e989

JingMatrix commented 1 year ago

My bad, I forgot to setup the click listeners for it. Now it is fixed.

chuwza commented 1 year ago

My bad, I forgot to setup the click listeners for it. Now it is fixed.

It works, thank you😄