JingMatrix / LSPosed

LSPosed Framework resuscitated
https://lsposed.org
GNU General Public License v3.0
1.99k stars 57 forks source link

Update Dependencies #12

Closed CanerKaraca23 closed 2 months ago

CanerKaraca23 commented 2 months ago
CanerKaraca23 commented 2 months ago

I also recommend you to drop riru support.

JingMatrix commented 2 months ago

The build didn't pass, please fix the gradle wrapper

CanerKaraca23 commented 2 months ago

The build didn't pass, please fix the gradle wrapper

Build passes normally for me on master branch but looks like we need to give permission to gradlew on PR branch.

Fixed.

JingMatrix commented 2 months ago

Thanks for the pull-request, feel free to contribute in the future.

CanerKaraca23 commented 2 months ago

Thanks for the pull-request, feel free to contribute in the future.

Thank you.

It seems Dependabot is not active in your repository. You need to enable Dependabot from repository settings - code security and analysis, enable everything.

JingMatrix commented 2 months ago

Dependent bot is too annoying by polluting the GitHub Actions page, and causiing unnecessary distractions. See comment: https://github.com/JingMatrix/LSPosed/pull/13#issuecomment-2323353461 And I almost have used my own versions for all submodules, it is thus better not to use dependent bot.

CanerKaraca23 commented 2 months ago

Dependent bot is too annoying by polluting the GitHub Actions page, and causiing unnecessary distractions. See comment: #13 (comment) And I almost have used my own versions for all submodules, it is thus better not to use dependent bot.

Disable this, it will not spam actions tab.

Screenshot_20240901-171357_Chrome

JingMatrix commented 2 months ago

Very strangely, the ConfigManger bug is caused by this commit. Bug: when you open the manager, you can no longer config the scope since the manager keep refreshing. Could you please comfirm it?

Maybe some update break stuffs that I cannot notice yet. I have to revert this commit.

CanerKaraca23 commented 2 months ago

Very strangely, the ConfigManger bug is caused by this commit. Bug: when you open the manager, you can no longer config the scope since the manager keep refreshing. Could you please comfirm it?

Maybe some update break stuffs that I cannot notice yet. I have to revert this commit.

I didn't understand what is the issue.

Edit: Oh, you're talking about on/off switch modules issue, right? I think i found it why. The issue is RikkaX widget mainswitchbar. Updating it breaks the on/off switch.

https://github.com/RikkaApps/RikkaX/commit/3dc0d92aae741ffe1a7c87cddb98c957fdcec422

JingMatrix commented 2 months ago

@CanerKaraca23 You are right, the problem is caused by the RikkaX widget mainswitchbar.

CanerKaraca23 commented 2 months ago

@CanerKaraca23 You are right, the problem is caused by the RikkaX widget mainswitchbar.

@JingMatrix Opened new PR.