search

JingMatrix / LSPosed

LSPosed Framework resuscitated
https://lsposed.org
GNU General Public License v3.0
1.99k stars 57 forks source link

CorePatch not fully functional on some devices #32

Closed Keeperorowner closed 1 month ago

Keeperorowner commented 1 month ago

Steps to reproduce/复现步骤

Install CorePatch, enable functions, restart, and install applications with different signatures

Expected behaviour/预期行为

Disabling the apk signature verification function takes effect

Actual behaviour/实际行为

Disable The apk signature verification function is disabled

Xposed Module List/Xposed 模块列表

rezygisk

Magisk Module List/Magisk 模块列表

zygisk_lsposed

LSPosed version/LSPosed 版本

1.10.0

Android version/Android 版本

14

Magisk version/Magisk 版本

Apatch

Riru version/Riru 版本

N/A

Version requirement/版本要求

Logs/日志

All modules use the debug version, but there are no useful logs either，If anyone else has this bug, please post your log，I can basically confirm that it is the problem of this lsposed framework, because I will not have this problem when I use the official version and other modified versions.Maybe it's because I'm using the Apatch instead of magisk

JingMatrix commented 1 month ago

By the way, if you try the version in GitHub Release, will CorePatch fully function?

Keeperorowner commented 1 month ago

Disabling the apk signature verification function using the release version also does not take effect

JingMatrix commented 1 month ago

@Keeperorowner Are you sure? I meant the version donwloaded from https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

Keeperorowner commented 1 month ago

@Keeperorowner Are you sure? I meant the version donwloaded from https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

I misunderstood what you meant earlier, but I have just tested with your Release version and found that the problem still exists and applications with different signatures still cannot override the installation😭😭

Keeperorowner commented 1 month ago

@Keeperorowner Are you sure? I meant the version donwloaded from https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

Do you still need me to provide a log

JingMatrix commented 1 month ago

found that the problem still exists and applications with different signatures still cannot override the installation😭😭

That shouldn't be, beacuse this version is basically the same with most popular forks.

It was a relase version, so logs are less information. But anyway, please upload one (who knows ?).

Keeperorowner commented 1 month ago

found that the problem still exists and applications with different signatures still cannot override the installation😭😭

That shouldn't be, beacuse this version is basically the same with most popular forks.

It was a relase version, so logs are less information. But anyway, please upload one (who knows ?).

LSPosed_2024-09-16T09_34_30.346585.zip by my real device

Keeperorowner commented 1 month ago

found that the problem still exists and applications with different signatures still cannot override the installation😭😭

That shouldn't be, beacuse this version is basically the same with most popular forks.

It was a relase version, so logs are less information. But anyway, please upload one (who knows ?).

I just used my Android 9 virtual machine to test, using Alpha mask, previously using the official version of lsposed, the core path is working, just now I installed your release version of lsposed, found that the core path function is also not working

Keeperorowner commented 1 month ago

Here's a copy of the virtual machine, Android 9 log LSPosed_2024-09-16T01_23_35.633.zip

JingMatrix commented 1 month ago

Aha, this time the log is relevant and tells where the problem is. Interesting.

JingMatrix commented 1 month ago

Your OnePlus device is Android 14, but in the logs of 2024-09-16T09:07:25.066171,

[ 2024-09-16T09:16:19.970    10644: 10065: 10065 I/Magisk          ] Magisk 6066b5cf(25200) daemon started
[ 2024-09-16T09:16:19.971    10644: 10065: 10065 E/Magisk          ] open: /sys/fs/cgroup/cgroup.procs failed with 13: Permission denied
[ 2024-09-16T09:16:19.972    10644: 10065: 10065 D/Magisk          ] resetprop: prop [ro.config.per_app_memcg] does not exist
[ 2024-09-16T09:16:19.972    10644: 10065: 10065 E/Magisk          ] open: /dev/memcg/apps/cgroup.procs failed with 13: Permission denied
[ 2024-09-16T09:16:19.972    10644: 10065: 10065 I/Magisk          ] * Device API level: 28
[ 2024-09-16T09:16:19.985    10644: 10065: 10068 D/Magisk          ] resetprop: getprop [ro.crypto.state]: [unsupported]
[ 2024-09-16T09:16:19.985    10644: 10065: 10068 I/Magisk          ] ** post-fs-data mode running
[ 2024-09-16T09:16:19.985    10644: 10065: 10068 E/Magisk          ] opendir: /dev/block failed with 13: Permission denied

It is reported by Magisk that you are using Android 9 (Device API level: 28), which causes the failure of CorePatch.

Please update your Magisk or disable some related modules that "change" the API level.

Keeperorowner commented 1 month ago

This appears to be the content of my virtual machine log, and I can't seem to change the built-in magisk version of the virtual machine

Keeperorowner commented 1 month ago

And the core path should be adapted to Android 9 to Android 15, it should not fail🤔

JingMatrix commented 1 month ago

Then please upload the log from your devices with the GitHub Release version.

I don't think that your virtual machine could prentend to be a OnePlus/PJE110.

Keeperorowner commented 1 month ago

Then please upload the log from your devices with the GitHub Release version.

I don't think that your virtual machine could prentend to be a OnePlus/PJE110.

Then you can take a look at my real machine log LSPosed_2024-09-16T16_11_02.585001.zip

Keeperorowner commented 1 month ago

I just submitted the issue under the core path and asked them to check the problem as well，Maybe it's a compatibility issue with the module itself

JingMatrix commented 1 month ago

This is the related part of CorePatch crash:

java.lang.ClassNotFoundException: Didn't find class "android.content.pm.PackageParser.PackageParserException" on path: DexPathList[[zip file "/system/framework/com.android.location.provider.jar", zip file "/system/framework/services.jar", zip file "/system/framework/oplus-services.jar", zip file "/system/framework/oplus-service-jobscheduler.jar", zip file "/apex/com.android.adservices/javalib/service-adservices.jar", zip file "/apex/com.android.adservices/javalib/service-sdksandbox.jar", zip file "/apex/com.android.appsearch/javalib/service-appsearch.jar", zip file "/apex/com.android.art/javalib/service-art.jar", zip file "/apex/com.android.configinfrastructure/javalib/service-configinfrastructure.jar", zip file "/apex/com.android.healthfitness/javalib/service-healthfitness.jar", zip file "/apex/com.android.media/javalib/service-media-s.jar", zip file "/apex/com.android.ondevicepersonalization/javalib/service-ondevicepersonalization.jar", zip file "/apex/com.android.permission/javalib/service-permission.jar", zip file "/apex/com.android.rkpd/javalib/service-rkp.jar"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64, /system/lib64, /system_ext/lib64]]

Please use the debug version of CorePatch and upload logs again.

happypotter321 commented 1 month ago

Same issue here, on android 13. Tried with magisk alpha, kitsune mask, the original magisk latest stable release. Corepatch works fine with lposedmod 1.9.3. I'll try to post a log later.

happypotter321 commented 1 month ago

LSPosed_2024-09-16T18_17_06.698778.zip

Keeperorowner commented 1 month ago

This is the related part of CorePatch crash:

java.lang.ClassNotFoundException: Didn't find class "android.content.pm.PackageParser.PackageParserException" on path: DexPathList[[zip file "/system/framework/com.android.location.provider.jar", zip file "/system/framework/services.jar", zip file "/system/framework/oplus-services.jar", zip file "/system/framework/oplus-service-jobscheduler.jar", zip file "/apex/com.android.adservices/javalib/service-adservices.jar", zip file "/apex/com.android.adservices/javalib/service-sdksandbox.jar", zip file "/apex/com.android.appsearch/javalib/service-appsearch.jar", zip file "/apex/com.android.art/javalib/service-art.jar", zip file "/apex/com.android.configinfrastructure/javalib/service-configinfrastructure.jar", zip file "/apex/com.android.healthfitness/javalib/service-healthfitness.jar", zip file "/apex/com.android.media/javalib/service-media-s.jar", zip file "/apex/com.android.ondevicepersonalization/javalib/service-ondevicepersonalization.jar", zip file "/apex/com.android.permission/javalib/service-permission.jar", zip file "/apex/com.android.rkpd/javalib/service-rkp.jar"],nativeLibraryDirectories=[/system/lib64, /system_ext/lib64, /system/lib64, /system_ext/lib64]]

Please use the debug version of CorePatch and upload logs again.

There are other people who have the same problem as me and also upload a log using the debug version LSPosed_2024-09-16T22_11_15.168245.zip

JingMatrix commented 1 month ago

Could you please try the latest build: https://github.com/JingMatrix/LSPosed/actions/runs/10888090132 ?

In case this isn't fixed, please upload logs, thanks.

Keeperorowner commented 1 month ago

Could you please try the latest build: https://github.com/JingMatrix/LSPosed/actions/runs/10888090132 ?

In case this isn't fixed, please upload logs, thanks.

It doesn't seem to work.Attach the log LSPosed_2024-09-17T02_23_25.621675.zip

JingMatrix commented 1 month ago

@Keeperorowner Could you please also try the release build of CI? It is strange that the logs you updated was totally normal. Maybe a release version gives better relevant logs.

happypotter321 commented 1 month ago

Update:

So I tried the release build for lposed from the link you provided (7096) and that made downgrading applications possible with the release build of core patch. However, installing applications with different signatures, or applications with no signatures weren't possible. (both possible with lposed mod, but disable digest verify has to be enabled still for it to be possible to install applications with no signatures)

Enabling "Disable digest Verify" in Core Patch settings made it possible to install applications with no signatures, but installing apps with different signatures is still not possible even with any combination of the settings toggled in core patch (also tried enabling all the settings on it)

Here's the log with all the settings enabled in core patch. (nothing except for disable digest verify seemed to do anything though) LSPosed_2024-09-17T04_07_57.496895.zip

happypotter321 commented 1 month ago

After that, I tried the Debug build from the link you provided (7096), and same issue. The logs looked a little bit different though, but I don't know what that means. No idea if this would help but here's the file. [Uploading LSPosed_2024-09-17T04_13_47.924748.zip…]()

Keeperorowner commented 1 month ago

@Keeperorowner Could you please also try the release build of CI? It is strange that the logs you updated was totally normal. Maybe a release version gives better relevant logs.

Using the release version, the problem still exists, you look at the log LSPosed_2024-09-17T09_52_15.220079.zip

Keeperorowner commented 1 month ago

Could you please try the latest build: https://github.com/JingMatrix/LSPosed/actions/runs/10888090132 ?

In case this isn't fixed, please upload logs, thanks.

It doesn't seem to work.Attach the log LSPosed_2024-09-17T02_23_25.621675.zip

I found an interesting thing, when I use the core path module, disable the apk verification function can not take effect, but when I use the lucky cracker xposed core path, it seems to run very normal, apk with different signatures can be installed normally, perhaps the core path module problem

JingMatrix commented 1 month ago

Now both of your logs are normal, and I cannot find any possible abnormalstuff. @Keeperorowner Could you try debug versions on your virtual machine and upload logs? Thanks.

Keeperorowner commented 1 month ago

In the virtual machine, the latest build of lsposed can already use the core path normally, the release version using the core path will have a bug, it should be the recent several fixes have taken effect

JingMatrix commented 1 month ago

In the virtual machine, the latest build of lsposed can already use the core path normally, the release version using the core path will have a bug

What did you mean here? The debug verison of CI build works but the release version of CI build doesn't?

Keeperorowner commented 1 month ago

The 7068 version is not available on virtual machines, and the 7097 version can normally use the core path

Keeperorowner commented 1 month ago

In the virtual machine, the latest build of lsposed can already use the core path normally, the release version using the core path will have a bug

What did you mean here? The debug verison of CI build works but the release version of CI build doesn't?

Both the release and debug versions built by cl can be used on virtual machines

JingMatrix commented 1 month ago

Both the release and debug versions built by cl can be used on virtual machines

So I think 7097 should work well on your device. The logs seemed also normal. Maybe you could clear the data of CorePatch ?

Uggpic commented 1 month ago

By the way, I have a similar problem. I posted the complete table at LSPosed_mod https://github.com/mywalkb/LSPosed_mod/issues/145

Unable to install unsigned files and replacing the signature does not work. Do you think it is caused by the Google Play system update patch? Screenshot

top1

top2

JingMatrix commented 1 month ago

@Uggpic Please try the latest CI build and upload your logs.

Uggpic commented 1 month ago

@JingMatrix LSPosed_2024-09-17T23_27_13.425359.zip Here is the latest version, I didn't find any new version...please correct me if I am wrong https://github.com/JingMatrix/LSPosed/releases/tag/v1.10.0

JingMatrix commented 1 month ago

@Uggpic I meant the build from GitHub Actions, currently the latest one is here: https://github.com/JingMatrix/LSPosed/actions/runs/10905173424

Uggpic commented 1 month ago

@Uggpic I meant the build from GitHub Actions, currently the latest one is here: https://github.com/JingMatrix/LSPosed/actions/runs/10905173424

Hey! It works, everything works as planned. Yes, I use zygisk-debug, here is the log LSPosed_2024-09-18T00_24_14.497390.zip

Keeperorowner commented 1 month ago

Both the release and debug versions built by cl can be used on virtual machines

So I think 7097 should work well on your device. The logs seemed also normal. Maybe you could clear the data of CorePatch ?

How can I completely clear its data if I uninstall and reinstall it and it still doesn't work

JingMatrix commented 1 month ago

@Keeperorowner I was suspecting that some setting of CorePatch might stop it from working properly. Could you please try more with different settings of CorePatch?

Also, there might be other APatch or LSPosed modules stop CorePatch. Could you please try disable them for test purpose?

JingMatrix commented 1 month ago

@Keeperorowner At least from the log, you settings of CorePatch is not the same as a fresh installed one.

privacyguy123 commented 1 month ago

I see an increasing number of people reporting this bug in the CorePatch Telegram, me included. Do you have any idea what would be causing a specific module not to work on your fork if your fork is based on the original Lsposed which reportedly this module works fine with?

JingMatrix commented 1 month ago

CorePatch always works well with JingMatrix/LSPosed on my device (Android 15) after my pull-request https://github.com/LSPosed/CorePatch/pull/115 is merged, so I was ignorant of this issue.

After some relevant logs are uploaded, I figured out the problem was related to my changes of the apache module org.apache.commons.lang3. Hence, commit 558aa09 should have closed this issue.

From partial test results, it already worked for Android 9, 12 and 13 devices. So if CorePatch still fails on your devices with the latest CI build of LSPosed, please then upload your logs to help this issue. Current known logs didn't help me to understand the cause yet.

privacyguy123 commented 1 month ago

I cannot install packages with different signatures currently - I see nothing in logs that would help debug this at all, there are no errors from CorePatch.

JingMatrix commented 1 month ago

Sorry, I made a mistake regarding the git commits. Some changed wasn't uploaded (due to some rebase error I guess). Now I have fixed the commit e365baf. Please try the latest CI build https://github.com/JingMatrix/LSPosed/actions/runs/10920996299, and tell me if everything works well.

happypotter321 commented 1 month ago

Still can't install apps with different signatures on the build you linked (7096) I tried the release version btw. LSPosed_2024-09-18T18_44_11.701181.zip

JingMatrix commented 1 month ago

@happypotter321 Your log was not uploaded sucessfully. Could you please upload it again? You may need to wait it a bit when you attach logs while editing your comments.

happypotter321 commented 1 month ago

Done (edited the comment and re-uploaded the file) sorry about that, didn't know it was a thing.

JingMatrix commented 1 month ago

@happypotter321 Could you please record logs while you failed to install apps with different signature ? Simply run:

adb logcat > full.log

And then upload full.log file.

happypotter321 commented 1 month ago

For privacy reasons, I decided to delete the entries before what can be seen here. This is the part from where the package manager seemed to have initiated and stuff (although at the top I guess it's just google play protect, I mean I disabled it so, but I included it just in case cause I'm not sure), after that nothing was edited. I hope that's okay, if not I can try to change some stuff on my device later and upload an unedited log. But yeah the stuff before seemed to be unrelated.

Somewhere around line 43 is where it happened I think.

full.log

Edit: didn't realize lposed log archive already contained a "full.log" oof.