search

JingweiToo / Wrapper-Feature-Selection-Toolbox-Python

This toolbox offers 13 wrapper feature selection methods (PSO, GA, GWO, HHO, BA, WOA, and etc.) with examples. It is simple and easy to implement.
BSD 3-Clause "New" or "Revised" License
251 stars 69 forks source link

A bug in function `boundary` (pso.py). #10

Closed lichunown closed 3 years ago

lichunown commented 3 years ago

The origin boundary will return the boundary lb and ub if x is overspill. however, what we need limited is the overspill value instead of the whole vector.

JingweiToo commented 3 years ago

The lb and ub are designed based on articles, and they are also changeable based on other design structures. In addition, there are many ways to design the algorithm boundary, constraints based on specific problems.

Moreover, I apply the same ub and lb to the whole vector because they are all representing the features. And I am using a threshold to determine the selected features.

lichunown commented 3 years ago

Thanks, but in my experiments, the limitation in overspill value would perform better. And it is not make sense if we use the whole vertor to limit the boundary.

JingweiToo commented 3 years ago

Yes, I am using the simplest form. We may also change the boundary for each feature too