search

Jinjinov / Usb.Events

Subscribe to the Inserted and Removed events to be notified when a USB drive is plugged in or unplugged, or when a USB device is connected or disconnected. Usb.Events is a .NET Standard 2.0 library and uses WMI on Windows, libudev on Linux and IOKit on macOS.
MIT License
95 stars 23 forks source link

Fixed memory leak and made changes to specify subsystem to filter on under Linux...needs refactoring #3

Closed maskimthedog closed 3 years ago

maskimthedog commented 3 years ago

Fixed memory leak and made changes to specify subsystem to filter on under Linux...needs refactoring

Jinjinov commented 3 years ago

I have tried to review your changes, but you changed the spaces to tabs, so now every line in the file is marked as changed, making the task very difficult. You can see that GitHub indicates that you removed 635 lines and added 669 lines. I would be happy to review your code if you commit only the relevant changes. Before I commit I usually review all the changes with a diff tool to make certain that I didn't change anything I didn't intend to.

maskimthedog commented 3 years ago

Oh, sorry about that. My editor did that automatically. I will fix it and do another PR.

On Sat, Jan 30, 2021 at 3:10 AM Urban notifications@github.com wrote:

I have tried to review your changes, but you changed the spaces to tabs, so now every line in the file is marked as changed, making the task very difficult. You can see that GitHub indicates that you removed 635 lines and added 669 lines. I would be happy to review your code if you commit only the relevant changes. Before I commit I usually review all the changes with a diff tool to make certain that I didn't change anything I didn't intend to.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Jinjinov/Usb.Events/pull/3#issuecomment-770175581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJZCEGODCFRVYCRAVDA4RQTS4O5GBANCNFSM4WZTRKBA .

-- *Rob Krakora*, Senior Embedded Engineer p: 317.661. <(317)%20661-4800>4794 f: 317.661.4801 <(317)%20661-4801> w: mesh-systems.com https://twitter.com/mesh_systems https://www.linkedin.com/company/mesh-systems-llc Watch Our Corporate Overview https://youtu.be/UGs-HR7KQQ8

maskimthedog commented 3 years ago

Hello,

I fixed the formatting. The C file diff looks good under GitHub, but the C# does not. When I clone my fork and your master and compare locally on my development desktop, the C# file only shows the few changes I made differing.

Best Regards,

Rob

*Rob Krakora*, Senior Embedded Engineer p: 317.661. <(317)%20661-4800>4794 f: 317.661.4801 <(317)%20661-4801> w: mesh-systems.com https://twitter.com/mesh_systems https://www.linkedin.com/company/mesh-systems-llc Watch Our Corporate Overview https://youtu.be/UGs-HR7KQQ8

On Sat, Jan 30, 2021 at 3:43 AM Rob Krakora rob.krakora@mesh-systems.com wrote:

Oh, sorry about that. My editor did that automatically. I will fix it and do another PR.

On Sat, Jan 30, 2021 at 3:10 AM Urban notifications@github.com wrote:

I have tried to review your changes, but you changed the spaces to tabs, so now every line in the file is marked as changed, making the task very difficult. You can see that GitHub indicates that you removed 635 lines and added 669 lines. I would be happy to review your code if you commit only the relevant changes. Before I commit I usually review all the changes with a diff tool to make certain that I didn't change anything I didn't intend to.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Jinjinov/Usb.Events/pull/3#issuecomment-770175581, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJZCEGODCFRVYCRAVDA4RQTS4O5GBANCNFSM4WZTRKBA .

-- *Rob Krakora*, Senior Embedded Engineer p: 317.661. <(317)%20661-4800>4794 f: 317.661.4801 <(317)%20661-4801> w: mesh-systems.com https://twitter.com/mesh_systems https://www.linkedin.com/company/mesh-systems-llc Watch Our Corporate Overview https://youtu.be/UGs-HR7KQQ8