Jinjinov
commented
3 years ago Thank you for submitting your changes.
As much as I would like to merge this version with my code, there are too many significant changes at once - GitHub indicates 536 added and 504 deleted lines. I have to fully understand each change before I can include it in my code.
I will gladly merge your changes, once the appropriate steps are taken:
- first create a separate issue for each bug and/or feature request
- fully describe the proposed changes, referencing the file line where appropriate
- try to keep significant changes to a minimum
- do not change a line of code unless it is absolutely necessary
- adhere to existing coding style
- don't change spaces to tabs
- don't change Windows line endings (ASCII 13,10 - \r\n - CR/LF) to Linux line endings (ASCII 10 - \n - LF)
There is also no need to create a new pull request each time you make a commit - explanation: https://github.community/t/do-i-need-to-make-a-new-pull-request-for-every-commit/13098
Fixed memory leak and made changes to specify subsystem to filter on under Linux...needs refactoring.