jinmiaochen
commented
5 years ago Dear all,
Thanks for your feedback and apologies.
We will fix the bug and update github shortly.
Best Jinmiao
Jinmiao Chen Principal Investigator Single-cell computational Immunology Singapore Immunology Network (SIgN) Agency for Science, Technology and Research (A*STAR) 8A Biomedical Grove IMMUNOS bldg, Level 3, SINGAPORE 138648 Tel: 65-64070395 Fax: 65-64642056 chen_jinmiao@immunol.a-star.edu.sgmailto:chen_jinmiao@immunol.a-star.edu.sg http://www.sign.a-star.edu.sg/
From: Samuel Granjeaud notifications@github.com Sent: Monday, 25 March 2019 8:11 PM To: JinmiaoChenLab/cytofkit2 cytofkit2@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [JinmiaoChenLab/cytofkit2] FCS are mixed up (#6)
Hi,
We did a trial of cytofkit2. Unfortunately, it seems that the files might be mixed up. We did the same processing with cytofkit, without having the bug.
I think the problem in our case is due to the following lines L49-50. The file names are sorted and apply to the original files, which could leads to a mismatch if files on disk are not in the alphabetical order. I don't see any reason for renaming. Could you explain?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/JinmiaoChenLab/cytofkit2/issues/6, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AIe92ioHzg2BUtq7z8ilI0P3iSpWmBHEks5vaLzXgaJpZM4cGu63.
This e-mail and any attachments are only for the use of the intended recipient and may contain material that is confidential, privileged and/or protected by the Official Secrets Act. If you are not the intended recipient, please delete it or notify the sender immediately. Please do not copy or use it for any purpose or disclose the contents to any other person.
Hi,
We did a trial of cytofkit2. Unfortunately, it seems that the files might be mixed up. We did the same processing with cytofkit, without having the bug.
I think the problem in our case is due to the following lines L49-50. The file names are sorted and apply to the original files, which could leads to a mismatch if files on disk are not in the alphabetical order. I don't see any reason for renaming. Could you explain?
https://github.com/JinmiaoChenLab/cytofkit2/blob/ab567e9fb963672874a1e5309cc7ba871bf840d6/inst/shiny/server.R#L47-L51