search

Jinmo / applescript-disassembler

A simple run-only applescript disassembler
MIT License
112 stars 19 forks source link

Not able to launch the thing #1

Closed TyrfingMjolnir closed 6 years ago

TyrfingMjolnir commented 6 years ago

$ python2 ./disassembler.py /opt/dev/applescript/some.scpt Traceback (most recent call last): File "./disassembler.py", line 153, in main() File "./disassembler.py", line 20, in main f = load_file(path) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 253, in load_file r = readObject(0) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 223, in readObject data = readValueBlock(id, size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 90, in readValueBlock r = _readRefList(size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 78, in _readRefList R.append(findObject(refId)) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 66, in findObject refMap[refId] = readObject(refId) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 227, in readObject data = readUntypedPointerBlock(id, size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 101, in readUntypedPointerBlock r = _readRefList(size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 78, in _readRefList R.append(findObject(refId)) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 66, in findObject refMap[refId] = readObject(refId) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 223, in readObject data = readValueBlock(id, size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 90, in readValueBlock r = _readRefList(size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 78, in _readRefList R.append(findObject(refId)) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 66, in findObject refMap[refId] = readObject(refId) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 227, in readObject data = readUntypedPointerBlock(id, size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 101, in readUntypedPointerBlock r = _readRefList(size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 78, in _readRefList R.append(findObject(refId)) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 66, in findObject refMap[refId] = readObject(refId) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 229, in readObject data = readCodeId(size) File "/opt/dev/applescript-disassembler/engine/fasparser.py", line 111, in readCodeId constTable[v] = v NameError: global name 'constTable' is not defined

TyrfingMjolnir commented 6 years ago

I patched my fork to make it work: https://github.com/TyrfingMjolnir/applescript-disassembler/blob/master/engine/fasparser.py#L111

Jinmo commented 6 years ago

Thanks for the report! I forgot to update some bugfixes. I pushed the patch. Can I ask is it working now?

TyrfingMjolnir commented 6 years ago

If you clone from https://github.com/TyrfingMjolnir/applescript-disassembler it should work. I also update ReadMe and a pull request for you to pull it back into your repo.

TyrfingMjolnir commented 6 years ago

There are some more stuff that I did on my repo, but I'm not able to make another PR in the web inteface, I find web interfaces confusing.

Jinmo commented 6 years ago

Thanks! I'll check the PR now.