bug: Show posters/thumbnails not visible in Jellyfin

sannidhyaroy commented 3 months ago

Feature description

In Jellyfin, there's no image for a show in the Dashboard of the Web UI. It would be more intuitive to show the show thumbnail, and if it's not possible, at least to show the channel logo as a thumbnail.

Solution

No response

Additional context

No response

Acknowledgements

[X] I have searched the existing issues and this is a new and no duplicate or related to another open issue.
[X] I have written a short but informative title.
[X] I filled out all of the requested information in this issue properly.

rabilrbl commented 2 months ago

@sannidhyaroy What does the logs in jellyfin say?

sannidhyaroy commented 2 months ago

These are a portion of the logs related to this thread of Jellyfin:

Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/2408141079018.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/2408141079018.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/2408141430018.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/2408141430018.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/2408141763006.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/2408141763006.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/2408142853056.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/2408142853056.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/240814415006.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/240814415006.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/240814155018.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/240814155018.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/240814175019.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/240814175019.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/240814288028.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/240814288028.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)
Aug 14 18:32:40 raspberrypi jellyfin[578]: [18:32:40] [ERR] Failed to determine primary image aspect ratio for /jtvposter/2024-08-14/240814466031.jpg
Aug 14 18:32:40 raspberrypi jellyfin[578]: System.IO.FileNotFoundException: File not found
Aug 14 18:32:40 raspberrypi jellyfin[578]: File name: '/jtvposter/2024-08-14/240814466031.jpg'
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Jellyfin.Drawing.Skia.SkiaEncoder.GetImageSize(String path)
Aug 14 18:32:40 raspberrypi jellyfin[578]:    at Emby.Server.Implementations.Dto.DtoService.GetPrimaryImageAspectRatio(BaseItem item)

These logs are continuously generated while navigating within the Jellyfin Web UI. No matter which button (even those that aren't part of Live TV) you click in the Web UI, such logs are continuously generated.

mohit-kothari commented 2 months ago

@rabilrbl Is there any reason why jiotv_go has its own url for posters instead of using jio's urls directly?

I changed code to update icon url from /jtvposter/2024-09-02/240902146031.jpg to https://jiotv.catchup.cdn.jio.com/dare_images/shows/2024-09-02/240902146031.jpg and I can see thumbnails now.

rabilrbl commented 2 months ago

@rabilrbl Is there any reason why jiotv_go has its own url for posters instead of using jio's urls directly?

I changed code to update icon url from /jtvposter/2024-09-02/240902146031.jpg to https://jiotv.catchup.cdn.jio.com/dare_images/shows/2024-09-02/240902146031.jpg and I can see thumbnails now.

It's there for proxying requests through server. I can keep an option to disable it. It will work even if we provide entire server url instead

mohit-kothari commented 2 months ago

Yes, either that. Or we can add an variable to set thumbnail prefix address in env. Which means for someone who has fixed static address for their Jiotv_go server (which I am assuming most people running jellyfin will already have), we can pass http://<ipaddress>:5001/jtvposter in this variable and still have proxy. And if someone prefers to use jio's cdn directly, then can pass https://jiotv.catchup.cdn.jio.com/dare_images/shows. If this variable is set we can just appent it to thumbnail path.

rabilrbl commented 2 months ago

Yes, either that. Or we can add an variable to set thumbnail prefix address in env. Which means for someone who has fixed static address for their Jiotv_go server (which I am assuming most people running jellyfin will already have), we can pass http://<ipaddress>:5001/jtvposter in this variable and still have proxy. And if someone prefers to use jio's cdn directly, then can pass https://jiotv.catchup.cdn.jio.com/dare_images/shows. If this variable is set we can just appent it to thumbnail path.

I guess you're confused about the proxy request term. JioTV Go can find such addresses automatically. No need for manual config. When cdn proxy is disabled option will use jio CDN

mohit-kothari commented 2 months ago

Got it, but what i mean is let's see I am using proxy and want to use this server with jellyfin too. Then in that case of epg still returns urls starting with /jtvposter, then jellyfin won't be able to show images. Also EPG generation being seperate process, we cannot just pick current host name from incoming request right?

So how will jiotv_go know the host automatically?

rabilrbl commented 2 months ago

You're right. I forgot about epg command and epg generation do not have access host variables For now as a temporary fix and I don't have time. Will server posters directly from Jio CDN for epg files

rabilrbl commented 2 months ago

@mohit-kothari @sannidhyaroy I believe channel logos are visible? Because I didn't have any problems in jellyfin myself

mohit-kothari commented 2 months ago

@rabilrbl Channel logos have never been problem. We are talking about program poster.

sannidhyaroy commented 2 months ago

@mohit-kothari @sannidhyaroy I believe channel logos are visible? Because I didn't have any problems in jellyfin myself

Channel logos are shown correctly. I never had a problem with that.

prashantcruise commented 2 months ago

@mohit-kothari @sannidhyaroy I believe channel logos are visible? Because I didn't have any problems in jellyfin myself

Channel logos are shown correctly. I never had a problem with that.

Hey how you have setup jio tv in jellyfin? Live tv > add m3u playlist url still!! What am I missing?

sannidhyaroy commented 2 months ago

Hey how you have setup jio tv in jellyfin? Live tv > add m3u playlist url still!! What am I missing?

Live TV > Add M3U Tuner and save it. Next, add TV Guide Data Providers > XMLTV and save it.

JioTV-Go / jiotv_go