Added css style changes to look better

JioTV-Go / jiotv_go

Unlock the magic of JioTV across all your devices, without the need for the JioTV App. Crafted with love in Golang for a delightful blend of speed and efficiency! 🌟✨

https://jiotv_go.rabil.me/

Other

377 stars 98 forks source link

Added css style changes to look better #370

Closed vijayvcm closed 3 months ago

vijayvcm commented 3 months ago

I have updated a few tailwind css styles to look better instead of the old card-based grid.

Also added PWA Support

Check the screenshots below

Mobile

Tab

Desktop

NOTE: Dark mode still needs some improvements...

rabilrbl commented 3 months ago

Thanks a lot for this PR.

I wish you had discussed with me before this big PR with a proposal first. I don't agree with some styling changes here. I will modify this PR and state reasons when I get time.

rabilrbl commented 3 months ago

@vijayvcm Thanks for the PR. But who is @jarvisnexus ? Why are u making PR instead of them?

Regardless, I have taken a look. And I disagree with all your styling changes.

Reasons:

for the logo, we won't use official logos from Jio and we could get copyright strike takedown
the whole point of having HD and SD icon is to identify which channels are available in HD. And removing them makes the homepage look bland.
as for web epg section, I will be adding next 2 shows to be displayed there, that's why I left space.

As for PWA, I appreciate it. As I can't merge this PR, can u create a seperate PR only for PWA support?

jarvisnexus commented 3 months ago

Hey @rabilrbl

It's just my other account. I just transferred the ownership to my other account so as not to mix with my personal repositories and forked repositories.

Nothing else to worry about.

Yes, I should have talked to you before implementing changes.

To answer your points/question,

Yes, I should not have used the official Jiotv logo.
I never looked at SD and HD badges because I always search with the channel name and HD channel names include HD text at the end. Also, I see some of the logos have HD in them. The badges look flashy and I can't focus on the logos clearly. That's why I removed it. Anyway, keeping it is also fine for me.
web epg section, I am ok with it.

Anyway, I will make a new PR with just PWA support