Jip-Hop / sedunlocksrv-pba

Conveniently unlock your Self Encrypting Drive on startup (via HTTPS) without the need to attach monitor and keyboard
GNU General Public License v3.0
36 stars 8 forks source link

Allow exclusion of network device(s) #10

Closed kennethso168 closed 1 year ago

kennethso168 commented 1 year ago

As mentioned in #9 I intended to have a virtualized router on the server with SED-protected disk. I found that the PBA image will try to configure all network devices with dynamic IP addresses using DHCP, and the web server and SSH server will listen on all interfaces. That may not be desirable in my case as this will inadvertently expose the web server and SSH server to the Internet.

And I have implemented exclusion of network device(s) as well in my fork. Here is a screenshot of this in action in my Proxmox VM (eth1 and eth2 being excluded for DHCP broadcasting): image

Would you like me to open a PR for this?

Jip-Hop commented 1 year ago

Yes please open a PR. Looks neat and already complete with updated Readme. 😄