search

Jip-Hop / sedunlocksrv-pba

Conveniently unlock your Self Encrypting Drive on startup (via HTTPS) without the need to attach monitor and keyboard
GNU General Public License v3.0
37 stars 8 forks source link

Error data queue siser is too large with unsquashfs use mount #26

Closed korentzari closed 5 months ago

korentzari commented 5 months ago

When docker execute build.sh 

+ touch cache/dep/bash.tcz.dep
+ unsquashfs -f -d /tmp/img.grHVZL/core cache/tcz/bash.tcz
FATAL ERROR: Data queue size is too large

I have replace unsquashfs by mount and cp

++ mktemp -d --tmpdir=/tmp mnt.XXXXXX
+ MOUNTDIREXT=/tmp/mnt.GVEVqs

+ mount -o loop cache/tcz/bash.tcz /tmp/mnt.GVEVqs
+ cp -r /tmp/mnt.GVEVqs/usr /tmp/img.xAjeYa/core/
+ umount /tmp/mnt.GVEVqs
+ rm -rfv /tmp/mnt.GVEVqs
removed directory '/tmp/mnt.GVEVqs'
korentzari commented 5 months ago

I have replace unsquashfs by mktmpdir ; mount ; cp ; unmount ; rmtmpdir

Jip-Hop commented 5 months ago

Thanks for providing this PR. I never ran into the FATAL ERROR: Data queue size is too large myself and couldn't reproduce it. But regardless I think it's nice to eliminate the dependency on the squashfs-tools package. I've cherry picked your first commit. The second commit doesn't seem to belong to this PR. I don't really understand what the EFI stuff is supposed to do. Besides I won't accept a PR which changes the default build to enable SSH: CMD ./build.sh SSH. Feel free to open another PR if you want to merge the EFI code but please provide more/clear description of what it's supposed to do.

korentzari commented 5 months ago

Yes, you did the right thing. I should have created a dedicated branch for my MR. I will look to push EFI issues once I am satisfied with the result. My BIOS/UEFI removes entries no longer exist at each reboot, so as soon as I boot from the PBA (after shutdown, it removes the EFI entry to boot my Linux system). I just coded something to automatically recreate the entry once the disk is unlocked.