Jip-Hop / sedunlocksrv-pba

Conveniently unlock your Self Encrypting Drive on startup (via HTTPS) without the need to attach monitor and keyboard
GNU General Public License v3.0
37 stars 8 forks source link

Option to use other forks of sedutil #8

Closed kennethso168 closed 1 year ago

kennethso168 commented 1 year ago

Many thanks for the great project!

I have been using ChubbyAnt's fork of sedutil for my own server for its use of SHA-512 password algorithm instead of SHA-1 and additional support for AMD systems.

I have figured out the way to swap Drive-Trust-Alliance's sedutil-cli binary with ChubbyAnt's. Please see the relevant commit of my fork

I'm still thinking of a way to allow user to choose between the forks of sedutil used when running the build script. I'm leaning towards the use of environmental variables, e.g. SEDUTIL_FORK="ChubbyAnt" ./build.sh (the default being Drive-Trust-Alliance when the variable isn't defined).

Any ideas? If we agree on the way of implementation, I can modify the build script accordingly and prepare a PR.

Jip-Hop commented 1 year ago

Glad to hear the project is useful to you. 😄Your proposal to use an environment variable to override which sedutil fork to use sounds good! Looking forward to the pull request.

kennethso168 commented 1 year ago

Thanks, I'll modify the script and do the PR when free.