search

JiriHoffmann / react-native-clusterer

React Native clustering library using C++ Supercluster implementation
MIT License
159 stars 20 forks source link

[iOS] Map markers still visible on top of cluster after zooming out #13

Closed henrymoulton closed 8 months ago

henrymoulton commented 2 years ago

https://user-images.githubusercontent.com/30093692/185503537-68b49817-a858-4ba8-9b12-9c088b9fa2bd.mp4

Thanks for the library, it's really cool, I've noticed a bug with the example code, when you zoom back out the pins still appear. I'd expect the pins to disspear, right?

JiriHoffmann commented 2 years ago

Hmm... That is really odd! I've never seen this issue before and the same thing with the Google Maps issue. I'll try to take a look at it over the next weekend if I have some time.

henrymoulton commented 2 years ago

@JiriHoffmann I've noticed your example is running "react-native-maps": "^0.29.4", while I'm running "react-native-maps": "1.1.0",, will take a look quickly...

henrymoulton commented 2 years ago

Can confirm that your example does work so it's probably a problem on my end dependency wise

henrymoulton commented 2 years ago

I'm running "react-native": "0.66.4", example is "react-native": "0.66.3", so most likely the maps discrepancy.

JiriHoffmann commented 2 years ago

Yeah, that definitely could be it, it seems to be an issue with rerendering on the map rather than the clustering itself

henrymoulton commented 2 years ago

Looked into the release notes since 1.0 and couldn't see a good reason this would happen hmm.

henrymoulton commented 2 years ago

There is some mentions of a new Google Maps renderer but can't obviously this is Apple Maps, any thoughts @JiriHoffmann ?

henrymoulton commented 2 years ago

@JiriHoffmann I've noticed that sometimes with Storybook the clustering is fine and then when I turn off Storybook the map keeps default markers where there were previously clusters.

henrymoulton commented 2 years ago

I do think this is a react-native-maps bug, but unsure how to further debug...

henrymoulton commented 8 months ago

This turned out to be a bug with Reanimated.

cjones26 commented 3 months ago

@henrymoulton what was the Reanimated bug?