Use flask and makes it a WSGI application

JiriSko / amixer-webui

Web application for control ALSA volume

MIT License

53 stars 21 forks source link

Use flask and makes it a WSGI application #6

Closed marmeladema closed 7 years ago

marmeladema commented 7 years ago

Tested on python 2.7.9 and 3.4.2

Minor modifications:

check for root effective uid before calling alsactl store, this way we can use a non privileged user, but then we cannot store alsa config
use argparse module to parse arguments Ideas:
use jinja2 template engine (integrated with flask) for index / do not use templates at all for index ?

marmeladema commented 7 years ago

I forgot to change tests for flask. I'll to that in a few days. I lack of time right now.

JiriSko commented 7 years ago

Looks promising :) But needs a little work to do e.g. not working /card/ action (cannot change sound card right now).

marmeladema commented 7 years ago

I fixed some bugs, but in order to properly adapt tests i would have to import alsamixer-webui.py which is not possible because of the dash. Would you mind if i rename it to alsamixer_webui.py ?

JiriSko commented 7 years ago

Yes, I find out same issue a few days ago. At that time I decided to preserve name for backwards compatibility but now when there's different situation (new cli arguments) I think we can rename it. Just for backwards compatibility please create temporary alsamixer-webui.py script which calls new alsamixer_webui.py. :-)

marmeladema commented 7 years ago

Tests are actualy good but alsa is missing on travis ...

JiriSko commented 7 years ago

Missing alsa is problem but if there would be alsa available you cannot test it properly without sound card(s). Thus I decided to test only webserver itself and ignore this OSError exception.

marmeladema commented 7 years ago

Is this ok for merge ?

JiriSko commented 7 years ago

I'll look at it in second half of this week. ;)

JiriSko commented 7 years ago

I've checked it. :) I found several little issues - not working equalizer, can't change sound card and syntax error in init script. I fixed it. Also I've decided to delete old alsamixer-webui.py because I realized that it won't work because of new dependency on the flask. So good work, thanks! I'll merge it soon if there wouldn't be another issue. ;)