Closed sevein closed 6 years ago
https://github.com/artefactual/archivematica/pull/785 needs to be merged first and I'll update this PR accordingly.
We've found today that clamscan --max-filesize=
defaults to 25m
, meaning that we could have false negatives when the files is bigger than that. We've also found that the maximum value that we can pass to --max-filesize
is 4g
- I totally missed that while I was running my tests.
So I'll leave this PR open for now but the logic may change significantly. @ross-spencer may be working on this. Related: https://github.com/artefactual-labs/archivematica-acceptance-tests/issues/36.
@sevein do you want to assign this to me - I'll start looking at the required code changes.
@sevein do you want to assign this to me - I'll start looking at the required code changes.
Apparently I can't do that because you're not a member of the organization yet. I think that they're working on it.
Hmm, I'll talk to Justin - they added me and then removed me again the other day....
On Fri, Nov 17, 2017 at 1:50 PM, Jesús García Crespo < notifications@github.com> wrote:
@sevein https://github.com/sevein do you want to assign this to me - I'll start looking at the required code changes.
Apparently I can't do that because you're not a member of the organization yet. I think that they're working on it.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JiscRDSS/archivematica/pull/38#issuecomment-345111249, or mute the thread https://github.com/notifications/unsubscribe-auth/AByxXJeZ5UFOqW4nksrwIOVvHr8q7OZWks5s3NhegaJpZM4QTjcS .
@sevein should be able to assign this to me now.
It's all yours!
See https://github.com/artefactual/archivematica/pull/772 for more details.
This closes RDSSARK-287.