JitouchApp / Jitouch

A multi-touch extension for MacBook, Magic Mouse, and Magic Trackpad
GNU General Public License v3.0
391 stars 28 forks source link

Fix gesture preview crash in command sheet #35

Closed aaronkollasch closed 1 year ago

aaronkollasch commented 1 year ago

Opening the command sheet by clicking [+] or double-clicking a gesture, mousing over a gesture in the command sheet to show its gesture preview, and closing the sheet by pressing ESC, causes the PrefPane to crash. This is because the fade animation tries to remove the gesture preview child window from the command sheet after the command sheet has been closed.

This PR removes the fade animation responsible for the crash, and also removes it from gesture previews in the main tabs, as it wasn't being displayed. Attempts to add a background fade introduced a magenta flicker, as portions of windows with a background alpha ≤0.75 that exceed the bounds of the main window are given an opaque magenta background for security. Thus, the fade animation is being removed entirely.

This PR also reintroduces alpha=0.8 to the gesture preview window by using the correct background color (though no extra styling is included).