JitouchApp / Jitouch

A multi-touch extension for MacBook, Magic Mouse, and Magic Trackpad
GNU General Public License v3.0
396 stars 28 forks source link

Fixing 2 Bugs. jitouch now works on Ventura. #51

Closed supasorn closed 1 year ago

supasorn commented 1 year ago

Fix 2 bugs. It's now working on Ventura.

  1. moveresize() randomly crashes because NSWindow's updates are not performed in the main queue.
  2. Move-resize icon is not changing. The new OSX seems to require contentView's setNeedsDisplay set to YES, in order to redraw.

It's been almost a decade since I last used xcode / obj-c. So, please help review the changes.

supasorn commented 1 year ago

Yes, let me fix it real quick.

And thank YOU too for maintaining it and keeping it alive!!

Thanks for the PR, and for all your hard work on Jitouch! ❤️

I have one minor change, but otherwise this LGTM. Also, the same cursorWindow calls occur in gestureMagicMouseV(), if you'd care to fix that as well.

https://github.com/aaronkollasch/jitouch/blob/7f860a9b69e0ccab708381403e41f361487eb9e5/jitouch/Jitouch/Gesture.m#L2335

supasorn commented 1 year ago

I just converted the existing ones to @autoreleasepool. It seems like there are a lot more that could be converted,.. but seems like a big refactoring.

AJAYK-01 commented 1 year ago

Hey @aaronkollasch, I use Ventura 13.4 on Mac M1, and Jitouch works fine, but the preferences pane just doesn't stay open for me to change any setting. I am a Jitouch user since Big Sur, and therefore I have all my settings made back in the day. The current app works with those settings that I set then. But I cannot seem to change it due to this issue.

If a fix for this issue is unknown, could you give me something like the file location of these settings, so that I can maybe create a backup of it just in case I have to format my device or install on another device with the same settings that I have right now?

https://github.com/JitouchApp/Jitouch/assets/55079486/901a0d34-f1c2-4090-b742-d410bf4b24b5

aaronkollasch commented 1 year ago

Hi @AJAYK-01, That looks like a crash in Jitouch's Preference Pane. Could you make a separate issue for it?

The location of the settings is ~/Library/Preferences/com.jitouch.Jitouch.plist.

AJAYK-01 commented 1 year ago

Opened #71

AJAYK-01 commented 1 year ago

Hi @AJAYK-01, That looks like a crash in Jitouch's Preference Pane. Could you make a separate issue for it?

The location of the settings is ~/Library/Preferences/com.jitouch.Jitouch.plist.

Hey @aaronkollasch thanks for the settings file location, editing it via xcode editor works!

However could you also let me know where to find all the possible strings related to the trackpad gesture combinations as well as the possible actions it can do? This would help me add new gestures in the future if I needed.