JitseB / NPCLib

(Minecraft) NPCLib – Basic non-player character library.
MIT License
197 stars 49 forks source link

Cannot use on 1.12.2 Paper #136

Closed Xierip closed 3 years ago

Xierip commented 3 years ago

Describe the bug Just cannot use this lib.

NPCLib usage option I tried in all options.

NPCLib JAR name npclib-plugin-2.11.1-SNAPSHOT.jar

Server version Paper version git-Paper-1618 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

To Reproduce Steps to reproduce the behavior:

Expected behavior I want to spawn a NPC...

Mooselk commented 3 years ago

Can you provide the full class?

Xierip commented 3 years ago

@Mooselk image https://github.com/Xierip/TestNpcLib

Xierip commented 3 years ago

It happens every time :/

Mooselk commented 3 years ago

Looks like an issue with tinyprotocol, it’s probably incompatible with paper. I don’t know enough about it to fix it.

JitseB commented 3 years ago

I’ll see what I can do about it at the end of the week. I’m a bit busy at the moment.

JitseB commented 3 years ago

Can you link the URL to your specified PaperSpigot version? I can't seem to reproduce this issue using the latest version of PaperSpigot...

From what I see in the code is that there's a pending and confirmed array for the server connection class, at least in the 1.16.5 version. It doesn't seem plausible that this is what is causing this strange null pointer, so I will investigate that a little bit more.

Xierip commented 3 years ago

@JitseB This is weird, I runned now this same server, and now its working O_o I added it to minigame plugin and its working fine too.

Xierip commented 3 years ago

But on lobby plugin for minigame not working, server setup is equal image

Xierip commented 3 years ago

Oh ok, its issue with old protocollib plugin i think. Thats really weird

JitseB commented 3 years ago

Extraordinary. ProtocolLib should not interfere with TinyProtocollib. Good to hear that you got it working now! Also makes sense now that I can't reproduce it. I only have NPCLib and a test plugin on my server. Closing issue, if you happen to find that this issue is caused by something else, please do tell!