search

JiyaGupta-cs / ShopNex

React Ecommerce App
https://shopnex.vercel.app
90 stars 190 forks source link

Issues #183

Open Rajput-xv opened 2 months ago

Rajput-xv commented 2 months ago

Issue Description

  1. In ShopCategory two files were created, so merged in only one, adjusted colors according to light and dark theme, removed extra dropdown icon from sort functionality and alligned it to best possible way, added class name in p tag, present in div with classname 'shopcategory-indexSort'.

  2. Color changes according to light and dark in CartItems (css,jsx).

  3. Added link to footer logo, name of ecommerce and adjusted links in Footer (jsx,css).

  4. Added cursor functionality in Hero (css).

  5. Adjusted Full Section in NewsLetter (css). {aligned it according to best suitable style}.

Hi, I have already done all the updates and raised a pull request before raising issue in this section. I am sorry about this.

kindly assign this issue to me or whatever you need to do, do the needful. If you think all updates are good, then please merge my PR.

Rajput-xv commented 2 months ago

@JiyaGupta-cs ???

ivedmohan commented 2 months ago

@Rajput-xv It's not advised to add lots of features in one PR please split the features in different Issue also please don't create a PR before getting it assigned to you. Thankyou

Rajput-xv commented 2 months ago

@Rajput-xv It's not advised to add lots of features in one PR please split the features in different Issue also please don't create a PR before getting it assigned to you. Thankyou

Yes, It will not repeat from my side. Sorry, It was my first time and i didn't knew about it. So, how should i proceed?