search

Jma529 / teacozy

0 stars 0 forks source link

SUMMARY #5

Open rimmesbe opened 6 years ago

rimmesbe commented 6 years ago

Grade: Satisfactory

Summary: Nice job on this project, the site looks good. You used some good techniques and kept your code well organized. Take a look at the issues I created for some best practice tweaks as well as some new techniques you can start using. Another thing to look into is expanding your use of semantic tags. Here is a good article for getting started: https://www.pluralsight.com/guides/semantic-html?aid=701j0000001heIqAAI&promo=&oid=&utm_source=google&utm_medium=ppc&utm_campaign=CA_Dynamic&utm_content=&utm_term=&gclid=CjwKCAjwlrnNBRBMEiwApKU4PBiUM7wtxiyqNw-6Zoikh6ChlNul6tTL839Zj2h_JNTZcK6PE5WWlRoCiOYQAvD_BwE

Jma529 commented 6 years ago

Thanks Ryan. It's a bit confusing as this course hasn't taught us to use semantic tags, it's all been about divs so I feel like I'm learning the wrong method...but that article is really informative.

rimmesbe commented 6 years ago

Ya I didn't hold it against you, just something to look into for future growth.

On Fri, Jul 6, 2018 at 3:09 PM, Jma529 notifications@github.com wrote:

Thanks Ryan. It's a bit confusing as this course hasn't taught us to use semantic tags, it's all been about divs so I feel like I'm learning the wrong method...but that article is really informative.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Jma529/teacozy/issues/5#issuecomment-403122086, or mute the thread https://github.com/notifications/unsubscribe-auth/AJfw_MIdeR4u03ndgClWfqcu3lKbB4JWks5uD7XogaJpZM4VFwSi .