search

Jmeyer1292 / gl_depth_sim

Stand-alone depth camera simulation using opengl for hardware acceleration
GNU Lesser General Public License v3.0
79 stars 26 forks source link

Update to C++14 #8

Closed mpowelson closed 4 years ago

mpowelson commented 4 years ago

This is required for Noetic which uses PCL 1.10.

mpowelson commented 4 years ago

@levi-armstrong Are you a maintainer on this package?

marip8 commented 4 years ago

Does this actually change the standard to 14? I feel like I've used this command before and not seen it actually enable c++14 features (see this post). Previously I've had to use something like set(CMAKE_CXX_STANDARD 14).

Also in the interest of code quality, we should implement CI for this repository. Then we could prove that this change was effective

mpowelson commented 4 years ago

All I can say is that it worked for me. I'll leave CI to the maintainers of this repository.

Levi-Armstrong commented 4 years ago

Unfortunately I do not have merge rights.

schornakj commented 4 years ago

Unfortunately I do not have merge rights.

Should we fork this repo somewhere else, or should we ask @Jmeyer1292 to add another maintainer? I have a couple other things to fix as well.

marip8 commented 4 years ago

I have merge rights on this repository and can take care of PRs in the short term. I do think it would be a good idea to move this repository to a more publicly supported organization though