search

Jmeyer1292 / opw_kinematics

Closed form IK for parallel base, spherical wrist industrial manipulators
Apache License 2.0
71 stars 26 forks source link

Add windows build to ci #33

Closed Levi-Armstrong closed 5 years ago

Levi-Armstrong commented 5 years ago

@johnwason I took your implementation for integrating windows ci and made a few modifications. Can you take a look?

johnwason commented 5 years ago

Assuming the Travis CI build works it should be fine. I'd suggest moving the setup and batch files into the centralized CI test repo since it will be the same for all projects.

Levi-Armstrong commented 5 years ago

@gavanderhoorn Where do you think I should put the repository for holding the two .bat files for building on windows?

Levi-Armstrong commented 5 years ago

@johnwason I moved the two .bat file to my gist for now instead of creating a repository two host just these two file. Does any one see any issues with this?

johnwason commented 5 years ago

If you want to store it in a gist you could combine the two scripts into a single file and have a command line option to select "install" and "build". Batch file syntax is a little... different but it shouldn't be too difficult.

This is untested but should give the general idea

IF %1 == "install" (
   rem do install
   exit /b 0
)

IF %1 == "build" (
   rem do build
   exit /b 0
)

echo "Unknown command"
exit /b 1
gavanderhoorn commented 5 years ago

@gavanderhoorn Where do you think I should put the repository for holding the two .bat files for building on windows?

We could create a repository on ros-industrial.

It might also be nice to see whether we could upstream this to fi industrial_ci.

@ipa-mdl: have you considered adding Windows support?

Levi-Armstrong commented 5 years ago

@johnwason I tried the combined file approach but CI now keeps terminating because no output is recieved. Do you see any issues?

Also I had to remove the " to stop getting a syntax error but then ran into the issue previously described: cmd "/C call travis_ci_windows_install.bat" to cmd /C call travis_ci_windows_combined.bat build

johnwason commented 5 years ago

It looks like if you add a space after the argument it works. Try this:

cmd "/C call travis_ci_windows_combined.bat build "
Levi-Armstrong commented 5 years ago

@johnwason The extra space solved the problem.

Levi-Armstrong commented 5 years ago

It looks like everything is working now. It currently pulls a single gist file to build and install. @gavanderhoorn and @johnwason is there anything else that needs to be addressed before merging?

johnwason commented 5 years ago

Looks ok to me

Levi-Armstrong commented 5 years ago

@johnwason Is there anything that needs to be done for the shared libraries on windows build?

johnwason commented 5 years ago

This repo appears to be header only without libraries being built.

johnwason commented 5 years ago

See #34 for a cleaner option for Windows builds