Jmeyer1292 / opw_kinematics

Closed form IK for parallel base, spherical wrist industrial manipulators
Apache License 2.0
69 stars 26 forks source link

Address compiler warnings #37

Closed Levi-Armstrong closed 4 years ago

Levi-Armstrong commented 4 years ago

This addresses compiler warnings when using gcc.

Levi-Armstrong commented 4 years ago

Hm. A bit nasty these pragmas.

I can create macro to make it look more clean. Will that work?

Also this will make it easy to address different compilers without cluttering the main code.

Do we also only want to target GCC with this?

No, but I don't have an easy way to test windows compiler.

Levi-Armstrong commented 4 years ago

I created an opw_macros.h file and put all of the relevant macros in it. Also added support for clang but right now on windows the macros for ignoring warnings does nothing.

Levi-Armstrong commented 4 years ago

@gavanderhoorn What do you think about the changes?