search

Jmeyer1292 / opw_kinematics

Closed form IK for parallel base, spherical wrist industrial manipulators
Apache License 2.0
69 stars 26 forks source link

Updated CPack #66

Closed marip8 closed 2 years ago

marip8 commented 2 years ago

Use updated cpack macro in the boilerplate tools

Levi-Armstrong commented 2 years ago

Does this still generate the archive version (zip)?

Levi-Armstrong commented 2 years ago

Ah, I see now you move the cpack code to ros_industrial_cmake_boiler_plate. This is another package we could upgrade to using colcon like what we did in boost_plugin_loader for ubuntu and windows. We could also copy the CI scrips for uploading the archives.

marip8 commented 2 years ago

It would be a good idea to revamp the CI process to be ROS independent and to add the workflows for generating and uploading debians. We can do that in a separate PR. Also, I just removed the 0.2.16 tag of the boilerplate tools, so this PR won't work until we release that

Levi-Armstrong commented 2 years ago

It would be a good idea to revamp the CI process to be ROS independent and to add the workflows for generating and uploading debians. We can do that in a separate PR. Also, I just removed the 0.2.16 tag of the boilerplate tools, so this PR won't work until we release that

Yea, a separate PR sounds good.

Levi-Armstrong commented 2 years ago

@marip8 Is this good to merge?

marip8 commented 2 years ago

Yes, now that 0.2.16 on the boilerplate tools exists